Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle nil ParseableType from GVKParser #18154

Merged
merged 1 commit into from
May 9, 2024

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented May 9, 2024

fix: #18020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz requested a review from a team as a code owner May 9, 2024 17:22
@crenshaw-dev
Copy link
Collaborator

@leoluz which releases should we cherry-pick this to?

@todaywasawesome todaywasawesome enabled auto-merge (squash) May 9, 2024 17:48
@crenshaw-dev crenshaw-dev merged commit 62d9838 into argoproj:master May 9, 2024
27 checks passed
@leoluz
Copy link
Collaborator Author

leoluz commented May 9, 2024

/cherry-pick release-2.11

Copy link

Cherry-pick failed with Merge error 62d983807661019f83e27e0bee373ed587a7f57c into temp-cherry-pick-9472ab-release-2.11

@blakepettersson
Copy link
Member

/cherry-pick release-2.10

Copy link

Cherry-pick failed with Merge error 62d983807661019f83e27e0bee373ed587a7f57c into temp-cherry-pick-9472ab-release-2.10

@blakepettersson
Copy link
Member

Gah, I missed that gitops-engine has a bunch of client-go upgrades which makes backporting this fix to 2.10 impossible.

@crenshaw-dev
Copy link
Collaborator

Ugh. More reasons to merge gitops-engine back into the argo-cd repo.

mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic with ServerSideDiff=true (but without IncludeMutationWebhook=true)
4 participants