Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: proposal for enhancing scoped repository credentials #18290

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions docs/proposals/project-scoped-repository-enhancements.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ approvers:
- "@alexmt"

creation-date: 2024-05-17
last-updated: 2024-05-31
last-updated: 2024-06-04
---

# Project scoped repository credential enhancements
Expand Down Expand Up @@ -53,8 +53,11 @@ credentials. In the first case, we need to maintain backwards compatibility for
is that the API will return the first repository found matching the URL given. Since we now want to allow the same URL
to potentially be in multiple projects, we need to do some minor changes.

* If there is only one matching repository with the same URL and assuming the user is allowed to access it, use that repository
whether it is project-scoped or not. This is in line with the current behavior.
* If there is only one matching repository with the same URL, and assuming the user is allowed to access it _and_ there is
no app project given as a parameter, use that repository whether it is project-scoped or not. This is in line with the
blakepettersson marked this conversation as resolved.
Show resolved Hide resolved
current behavior.
* If there is only one matching repository with the same URL, and assuming the user is allowed to access it _and_ there is
an app project given as a parameter, use that repository only if it also matches the app project given.
* If there are multiple repositories with the same URL and assuming the user is allowed to access them, then setting a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* If there are multiple repositories with the same URL and assuming the user is allowed to access them, then setting a
* If there are multiple repositories with the same URL and assuming the user is allowed to access them, then setting a

project parameter would be required, since there would otherwise be no way to determine which of the credentials a user
wants to access. This is not a breaking change since this adds functionality which has previously not existed.
Expand Down
Loading