Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifests): initial Redis password timeout #18356 #18364

Closed
wants to merge 2 commits into from

Conversation

yz89122
Copy link

@yz89122 yz89122 commented May 22, 2024

Fixes #18356

This PR fixes error while deploying Argo CD v2.11.1 with create secret argocd-redis timeout.

This is fixed by introduce a new job to initial Redis password instead of do it in HA Proxy pods, which is blocked by network policy.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@yz89122 yz89122 force-pushed the fix/initial-redis-password branch from ec72b57 to 273376f Compare May 22, 2024 17:07
@yz89122 yz89122 changed the title fix(manifests): initial Redis password timeout fix(manifests): initial Redis password timeout #18356 May 22, 2024
@yz89122 yz89122 force-pushed the fix/initial-redis-password branch from 31edb46 to f8bf994 Compare May 22, 2024 17:17
@yz89122 yz89122 marked this pull request as ready for review May 22, 2024 17:26
@yz89122 yz89122 requested review from a team as code owners May 22, 2024 17:26
Signed-off-by: Yz C <yanzhen610@gmail.com>
@yz89122 yz89122 force-pushed the fix/initial-redis-password branch from f8bf994 to 1220c74 Compare May 22, 2024 17:28
Signed-off-by: Yz C <yanzhen610@gmail.com>
@yz89122 yz89122 force-pushed the fix/initial-redis-password branch from c01e9ec to 3c708b5 Compare May 23, 2024 02:39
@todaywasawesome
Copy link
Contributor

Closing in favor of #18367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argocd-redis secret-init initcontainer timeout
2 participants