-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(migrate): migrate otelgrpc pkg interceptor to stats handler(#18258) #18366
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18366 +/- ##
==========================================
+ Coverage 44.94% 44.95% +0.01%
==========================================
Files 354 353 -1
Lines 47740 47722 -18
==========================================
- Hits 21457 21454 -3
+ Misses 23481 23466 -15
Partials 2802 2802 ☔ View full report in Codecov by Sentry. |
464c408
to
37c0f77
Compare
[previous CI integratiion tests e2e log]
Modified the code based on the logs from the previous E2E test. |
migrate cmdserver, server, pkg/apiclient, reposerver - server - migrate ServerInterceptor -> NewServerHandler - client - migrate ClientInterceptor -> NewClientHandler fix server/application - add ClientStream GenerateManfiestWithFiles retry.Disable() remove util/grpc/trace - remvoe util/grpc/trace.go Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
37c0f77
to
c1e018a
Compare
@blakepettersson Can you check on that PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @Jack-R-lantern
This PR will migrate the otelgrpc pkg.
It changes server/clientinterceptor in otelgrpc to NewServer/ClientHandler
I think that otelgrpc should be updated to 0.52.0 or higher in the future, in which case grpc should also be updated to 1.64.
Closes #18258
Checklist: