chore(migrate): migrate mockery codegen to use packages(#18579) #18617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18617 +/- ##
==========================================
- Coverage 50.28% 50.26% -0.03%
==========================================
Files 312 315 +3
Lines 43025 43125 +100
==========================================
+ Hits 21635 21675 +40
- Misses 18908 18964 +56
- Partials 2482 2486 +4 ☔ View full report in Codecov by Sentry. |
Jack-R-lantern
force-pushed
the
ISSUE-18579/migrate_mockery_codegen_to_use_packages
branch
from
6c939e2
to
7d3b00e
Compare
migrate interface - remove go:generate - generate mock Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
add mockgen stage - add mockgen command to Makefile - add generate-mock.sh - add install mockery to install-codegen-go-tool.sh Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
Jack-R-lantern
force-pushed
the
ISSUE-18579/migrate_mockery_codegen_to_use_packages
branch
from
237ece3
to
3e67da3
Compare
ggjulio
pushed a commit
to ggjulio/argo-cd
that referenced
this pull request
Jul 21, 2024
… (argoproj#18617) * chore(migrate): mockery migrate to packages migrate interface - remove go:generate - generate mock Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> * chore(migrate: mockery migrate to package add mockgen stage - add mockgen command to Makefile - add generate-mock.sh - add install mockery to install-codegen-go-tool.sh Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> --------- Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
jsolana
pushed a commit
to jsolana/argo-cd
that referenced
this pull request
Jul 24, 2024
… (argoproj#18617) * chore(migrate): mockery migrate to packages migrate interface - remove go:generate - generate mock Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> * chore(migrate: mockery migrate to package add mockgen stage - add mockgen command to Makefile - add generate-mock.sh - add install mockery to install-codegen-go-tool.sh Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> --------- Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR resolves warns from mockery.
I migrated to using packages, and integrated with toolchain.
Close #18579
Checklist: