Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable require-error from testifylint on cmpserver and reposerver folders #18702

Merged

Conversation

mmorel-35
Copy link
Contributor

No description provided.

@mmorel-35 mmorel-35 requested a review from a team as a code owner June 17, 2024 16:17
Copy link

bunnyshell bot commented Jun 17, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.28%. Comparing base (4c6ad9d) to head (34b6d76).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18702   +/-   ##
=======================================
  Coverage   50.28%   50.28%           
=======================================
  Files         312      312           
  Lines       43020    43020           
=======================================
  Hits        21633    21633           
  Misses      18905    18905           
  Partials     2482     2482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ver folders

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the testifylint/cmpserver+reposerver branch from 2d19fff to 9dd5790 Compare June 17, 2024 18:04
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@ishitasequeira ishitasequeira merged commit 8f28199 into argoproj:master Jun 18, 2024
27 checks passed
@mmorel-35 mmorel-35 deleted the testifylint/cmpserver+reposerver branch June 18, 2024 03:34
ishitasequeira pushed a commit to ishitasequeira/argo-cd that referenced this pull request Jul 2, 2024
…ver folders (argoproj#18702)

* chore: enable require-error from testifylint on cmpserver and reposerver folders

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update app_k8s_events_test.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
ggjulio pushed a commit to ggjulio/argo-cd that referenced this pull request Jul 21, 2024
…ver folders (argoproj#18702)

* chore: enable require-error from testifylint on cmpserver and reposerver folders

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update app_k8s_events_test.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
jsolana pushed a commit to jsolana/argo-cd that referenced this pull request Jul 24, 2024
…ver folders (argoproj#18702)

* chore: enable require-error from testifylint on cmpserver and reposerver folders

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update app_k8s_events_test.go

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants