-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable require-error from testifylint on cmpserver and reposerver folders #18702
Merged
ishitasequeira
merged 2 commits into
argoproj:master
from
mmorel-35:testifylint/cmpserver+reposerver
Jun 18, 2024
Merged
chore: enable require-error from testifylint on cmpserver and reposerver folders #18702
ishitasequeira
merged 2 commits into
argoproj:master
from
mmorel-35:testifylint/cmpserver+reposerver
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
crenshaw-dev
approved these changes
Jun 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18702 +/- ##
=======================================
Coverage 50.28% 50.28%
=======================================
Files 312 312
Lines 43020 43020
=======================================
Hits 21633 21633
Misses 18905 18905
Partials 2482 2482 ☔ View full report in Codecov by Sentry. |
…ver folders Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2d19fff
to
9dd5790
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
ishitasequeira
approved these changes
Jun 18, 2024
ishitasequeira
pushed a commit
to ishitasequeira/argo-cd
that referenced
this pull request
Jul 2, 2024
…ver folders (argoproj#18702) * chore: enable require-error from testifylint on cmpserver and reposerver folders Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update app_k8s_events_test.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
ggjulio
pushed a commit
to ggjulio/argo-cd
that referenced
this pull request
Jul 21, 2024
…ver folders (argoproj#18702) * chore: enable require-error from testifylint on cmpserver and reposerver folders Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update app_k8s_events_test.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
jsolana
pushed a commit
to jsolana/argo-cd
that referenced
this pull request
Jul 24, 2024
…ver folders (argoproj#18702) * chore: enable require-error from testifylint on cmpserver and reposerver folders Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update app_k8s_events_test.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.