Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue in starting telepresence for remote debugging (Closes #18859) #18860

Merged

Conversation

thecooldrop
Copy link
Contributor

@thecooldrop thecooldrop commented Jun 30, 2024

Closes #18859.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@thecooldrop thecooldrop requested review from a team as code owners June 30, 2024 21:08
Copy link

bunnyshell bot commented Jun 30, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Jun 30, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: TheCoolDrop <vanio.begic123@gmail.com>
@pasha-codefresh pasha-codefresh changed the title Fix: Fix issue in starting telepresence for remote debugging (Closes #18859) fix: Fix issue in starting telepresence for remote debugging (Closes #18859) Jul 1, 2024
@pasha-codefresh pasha-codefresh enabled auto-merge (squash) July 1, 2024 07:17
@pasha-codefresh pasha-codefresh merged commit eca1f21 into argoproj:master Jul 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote debugging guide does not work as intended
2 participants