-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: health checks for Numaplane CRDs #19077
feat: health checks for Numaplane CRDs #19077
Conversation
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19077 +/- ##
=======================================
Coverage 50.65% 50.66%
=======================================
Files 315 315
Lines 43347 43347
=======================================
+ Hits 21959 21963 +4
+ Misses 18885 18882 -3
+ Partials 2503 2502 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@todaywasawesome Thanks for approval! Not sure why the license compliance is failing and blocking the merge. |
This pull request introduces the appropriate health checks for Numaplane CRDs which include
PipelineRollout
ISBServiceRollout
andNumaflowControllerRollout
Checklist: