Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: health checks for Numaplane CRDs #19077

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

dpadhiar
Copy link
Member

This pull request introduces the appropriate health checks for Numaplane CRDs which include PipelineRollout ISBServiceRollout and NumaflowControllerRollout

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Copy link

bunnyshell bot commented Jul 15, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Jul 15, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.66%. Comparing base (30a1623) to head (2db1504).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19077   +/-   ##
=======================================
  Coverage   50.65%   50.66%           
=======================================
  Files         315      315           
  Lines       43347    43347           
=======================================
+ Hits        21959    21963    +4     
+ Misses      18885    18882    -3     
+ Partials     2503     2502    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpadhiar dpadhiar marked this pull request as ready for review July 16, 2024 17:19
@dpadhiar dpadhiar requested a review from a team as a code owner July 16, 2024 17:19
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@todaywasawesome todaywasawesome enabled auto-merge (squash) July 17, 2024 15:27
@dpadhiar
Copy link
Member Author

@todaywasawesome Thanks for approval! Not sure why the license compliance is failing and blocking the merge.

@todaywasawesome todaywasawesome merged commit d6bc02b into argoproj:master Jul 17, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants