Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test experimental resource iteration algorithm #19090

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

crenshaw-dev
Copy link
Collaborator

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link

bunnyshell bot commented Jul 17, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-pyglde.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-pyglde.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Jul 17, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

…proj#18929)

NOTE: this PR right now refences a gitops-engine in a fork for testing purposes

Closes argoproj#18929
Helps with argoproj#18500
Use iterate hierarchy v2 to have a roughly linear performance for getting the resource tree instead of up to quadratic.
Also, use more lenient locking when processing events (part of gitops-engine changes).

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 32.50000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 50.64%. Comparing base (30a1623) to head (7f39fa4).

Files Patch % Lines
controller/appcontroller.go 40.62% 14 Missing and 5 partials ⚠️
controller/cache/cache.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19090      +/-   ##
==========================================
- Coverage   50.65%   50.64%   -0.02%     
==========================================
  Files         315      315              
  Lines       43347    43359      +12     
==========================================
+ Hits        21959    21960       +1     
- Misses      18885    18893       +8     
- Partials     2503     2506       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@todaywasawesome
Copy link
Contributor

🍿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants