Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Kustomize 1. Closes #1573 #2077

Merged
merged 4 commits into from Aug 2, 2019
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Aug 1, 2019

No description provided.

@alexec alexec self-assigned this Aug 1, 2019
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #2077 into master will decrease coverage by 0.34%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
- Coverage   35.89%   35.55%   -0.35%     
==========================================
  Files          88       88              
  Lines       12908    12827      -81     
==========================================
- Hits         4633     4560      -73     
- Misses       7636     7639       +3     
+ Partials      639      628      -11
Impacted Files Coverage Δ
reposerver/repository/repository.go 47.82% <100%> (-0.68%) ⬇️
util/kustomize/kustomize.go 73.68% <58.82%> (+5.62%) ⬆️
util/jwt/jwt.go 24.39% <0%> (-37.43%) ⬇️
server/project/project.go 58.52% <0%> (-2.72%) ⬇️
controller/appcontroller.go 40.33% <0%> (-1.37%) ⬇️
cmd/argocd/commands/app.go 0.74% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e15036...60b8260. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #2077 into master will decrease coverage by 0.04%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
- Coverage   35.66%   35.62%   -0.05%     
==========================================
  Files          88       88              
  Lines       12881    12827      -54     
==========================================
- Hits         4594     4569      -25     
+ Misses       7652     7626      -26     
+ Partials      635      632       -3
Impacted Files Coverage Δ
reposerver/repository/repository.go 47.82% <100%> (-0.68%) ⬇️
util/kustomize/kustomize.go 73.68% <58.82%> (+5.15%) ⬆️
controller/appcontroller.go 41.7% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588d302...d867cce. Read the comment docs.

@alexec alexec marked this pull request as ready for review August 1, 2019 23:41
@alexec alexec requested a review from jessesuen August 1, 2019 23:41
@alexmt alexmt added this to the v1.2 milestone Aug 1, 2019
@alexec alexec requested a review from alexmt August 2, 2019 00:11
@alexec alexec removed their assignment Aug 2, 2019
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address one comment before merging

@alexec alexec merged commit b49a0ce into argoproj:master Aug 2, 2019
@alexec alexec deleted the rm-k1 branch August 2, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants