Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1167 - Excluded known orphaned resources exceptions #2178

Merged

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Aug 20, 2019

ref: #1167

There are resources which are created in the namespace automatically and should not considered orphaned:

  • default service account
  • kubernetes service in default namespace

Such resources should be automatically ignored, instead of asking user to configure an exception

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval on making the suggested change.

controller/appcontroller.go Outdated Show resolved Hide resolved
controller/state_test.go Outdated Show resolved Hide resolved
@alexmt alexmt force-pushed the 1167-orphaned-resources-known-exceptions branch from f6bd345 to 4c1eca1 Compare August 20, 2019 22:31
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #2178 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2178      +/-   ##
==========================================
+ Coverage   37.29%   37.31%   +0.02%     
==========================================
  Files          97       97              
  Lines       13580    13564      -16     
==========================================
- Hits         5064     5062       -2     
+ Misses       7867     7854      -13     
+ Partials      649      648       -1
Impacted Files Coverage Δ
controller/appcontroller.go 44.15% <100%> (+0.56%) ⬆️
util/settings/settings.go 22.53% <0%> (-1.29%) ⬇️
cmd/argocd/commands/app_actions.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a1a77...4c1eca1. Read the comment docs.

@alexmt alexmt merged commit 83f58f2 into argoproj:master Aug 20, 2019
@alexmt alexmt deleted the 1167-orphaned-resources-known-exceptions branch August 20, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants