fix: Include resource group for events InvolvedObject.APIVersion #3011

[d-kuro]

close #3011
refs: kubernetes/kubernetes#87434

Details

Group is not included in involvedObject.apiVersion.

kubectl -n argocd get events -o yaml

apiVersion: v1
items:
- apiVersion: v1
  count: 1
  eventTime: null
  firstTimestamp: "2020-01-25T05:06:35Z"
  involvedObject:
    apiVersion: v1alpha1
    kind: Application
    name: foo
    namespace: argocd
    resourceVersion: "40528515"
    uid: b961e04b-3b7c-11ea-ac0c-0e7ae0cc4212
  kind: Event
  lastTimestamp: "2020-01-25T05:06:35Z"
  message: foo@example.com initiated sync to master (SHA1)
  metadata:
    creationTimestamp: "2020-01-25T05:06:35Z"
    name: foo.15ed08de6fe84a24
    namespace: argocd
    resourceVersion: "40528517"
    selfLink: /api/v1/namespaces/argocd/events/foo.15ed08de6fe84a24
    uid: 75e77984-3f30-11ea-964e-0ac522f51146
  reason: OperationStarted
  reportingComponent: ""
  reportingInstance: ""
  source:
    component: argocd-server
  type: Normal
...

Use func (GroupVersion) String function instead of gvk.Version.
https://godoc.org/k8s.io/apimachinery/pkg/runtime/schema#GroupVersion.String
kubernetes/kubernetes#87434 (comment)

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• I've signed the CLA and my build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #3031 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #3031   +/-   ##
=======================================
  Coverage   38.34%   38.34%           
=======================================
  Files         168      168           
  Lines       18133    18133           
  Branches      272      237   -35     
=======================================
  Hits         6953     6953           
- Misses      10311    10315    +4     
+ Partials      869      865    -4

Impacted Files	Coverage Δ
util/argo/audit_logger.go	0% <0%> (ø)	⬆️
ui/src/app/applications/components/utils.tsx	49.83% <0%> (ø)	⬆️
ui/src/app/shared/services/projects-service.ts	19.71% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b08a33...c819781. Read the comment docs.

[jannfis]

LGTM, thank you!

[travisghansen]

Nice!