fix: pass APIVersions value to manifest generation request during app validation and during app manifests loading #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validation and during app manifests loading
jannfis
requested changes
Mar 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #3312 +/- ##
==========================================
+ Coverage 38.83% 39.27% +0.44%
==========================================
Files 173 173
Lines 18830 18822 -8
Branches 272 272
==========================================
+ Hits 7313 7393 +80
+ Misses 10596 10499 -97
- Partials 921 930 +9
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Mar 30, 2020
… validation and during app manifests loading (#3312) * fix: pass APIVersions value to manifest generation request during app validation and during app manifests loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #3243 introduced support of
--api-versionsflag during helm chart rendering . The value for--api-versionsflag is supplied by application controller but does not supply by API server while executingCreateandGetManifestsAPI. This PR fixes that issue.