Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Whitelisted namespace in UI #3314

Merged
merged 12 commits into from
Mar 30, 2020
Merged

feat: Whitelisted namespace in UI #3314

merged 12 commits into from
Mar 30, 2020

Conversation

rachelwang20
Copy link
Contributor

@rachelwang20 rachelwang20 commented Mar 30, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Issue link: #2900

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #3314 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
+ Coverage   39.25%   39.28%   +0.03%     
==========================================
  Files         175      175              
  Lines       19018    18956      -62     
  Branches      272      237      -35     
==========================================
- Hits         7465     7447      -18     
+ Misses      10626    10591      -35     
+ Partials      927      918       -9     
Impacted Files Coverage Δ
ui/src/app/shared/models.ts 100.00% <ø> (ø)
ui/src/app/shared/services/projects-service.ts 19.71% <ø> (ø)
server/application/application.go 28.55% <0.00%> (-0.04%) ⬇️
ui/src/app/applications/components/utils.tsx 49.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71bfc6...2e1a15b. Read the comment docs.

@jannfis
Copy link
Member

jannfis commented Mar 30, 2020

Seems I missed the UI part when updating the contribution guide. Fix underway @ #3315. Sorry for that, @rachelwang20

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR @rachelwang20 . Added two minor comments. Also please resolve linter warning:

yarn run v1.19.1
$ tslint -p ./src/app

ERROR: /Users/amatyushentsev/root/go/src/github.com/argoproj/argo-cd/ui/src/app/settings/components/project-edit-panel/project-edit-panel.tsx:21:1 - Exceeds maximum line length of 180
ERROR: /Users/amatyushentsev/root/go/src/github.com/argoproj/argo-cd/ui/src/app/settings/components/project-edit-panel/project-edit-panel.tsx:21:29 - Replace `sourceRepos:·[],·destinations:·[],·roles:·[],·syncWindows:·[],·clusterResourceWhitelist:·[],·namespaceResourceBlacklist:·[],·namespaceResourceWhitelist:·[],·...props.defaultParams` with `⏎················sourceRepos:·[],⏎················destinations:·[],⏎················roles:·[],⏎················syncWindows:·[],⏎················clusterResourceWhitelist:·[],⏎················namespaceResourceBlacklist:·[],⏎················namespaceResourceWhitelist:·[],⏎················...props.defaultParams⏎············`

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@rachelwang20 rachelwang20 merged commit 00d4491 into argoproj:master Mar 30, 2020
@rachelwang20 rachelwang20 self-assigned this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants