New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement GKE ManagedCertificate CRD health checks #3600
feat: Implement GKE ManagedCertificate CRD health checks #3600
Conversation
I'm having some issues setting up my local environment, i'm following https://argoproj.github.io/argo-cd/developer-guide/contributing I will continue to try and make it work but i figured that health checks tests run in the CI too? |
Hi @micke, thanks for your contribution! If you need any support with setting up your toolchain, feel free to ask anything and also to suggest improvements to the documentation! As for your question, yes, the health checks will run in the CI too (or when running |
@jannfis Thanks for the quick response! I triggered another build and it looks like it's running now! Cheers! |
I'm not sure but i think the last failing check is something i can't really do anything about. So i guess this is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @micke
Checklist: