Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort application summary images and urls to avoid unnecessary updates #3848

Merged
merged 1 commit into from Jun 25, 2020

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 25, 2020

PR ensures that application summary URLs and Images are sorted. This allows avoiding updating application CR if images/url order is the only change.

@alexmt alexmt requested a review from jannfis June 25, 2020 16:34
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #3848 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3848      +/-   ##
==========================================
- Coverage   42.16%   42.14%   -0.02%     
==========================================
  Files         119      119              
  Lines       17421    17427       +6     
==========================================
  Hits         7345     7345              
- Misses       9133     9139       +6     
  Partials      943      943              
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 59.95% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4ac1f...b0b09e7. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit aee6003 into argoproj:master Jun 25, 2020
@alexmt alexmt deleted the 3730-sort-summary branch June 25, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants