Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not include kube-api check in application liveness flow #4163

Merged
merged 2 commits into from Aug 26, 2020

Conversation

olegsu
Copy link
Member

@olegsu olegsu commented Aug 26, 2020

Fix #4154
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@codecov-commenter
Copy link

Codecov Report

Merging #4163 into master will increase coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4163      +/-   ##
==========================================
+ Coverage   42.81%   42.92%   +0.11%     
==========================================
  Files         124      124              
  Lines       18288    18285       -3     
==========================================
+ Hits         7830     7849      +19     
+ Misses       9456     9430      -26     
- Partials     1002     1006       +4     
Impacted Files Coverage Δ
controller/appcontroller.go 51.11% <0.00%> (+2.07%) ⬆️
server/server.go 56.50% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8a8f0...f1cc07a. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @olegsu ! LGTM

@alexmt alexmt merged commit 3a50f8d into argoproj:master Aug 26, 2020
alexmt pushed a commit that referenced this pull request Aug 31, 2020
* feat: do not include kube-api liveness check in application liveness flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API server/controller health check should not try to connect to Kubernetes
3 participants