Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix rendering external links on application details page #4847

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Nov 16, 2020

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Supports changes introduced in #4380: properly render external links with title separated by | character.

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #4847 (831111b) into master (e4e503a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4847   +/-   ##
=======================================
  Coverage   41.35%   41.35%           
=======================================
  Files         127      127           
  Lines       17693    17693           
=======================================
  Hits         7317     7317           
  Misses       9321     9321           
  Partials     1055     1055           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e503a...831111b. Read the comment docs.

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit a2d6582 into argoproj:master Nov 17, 2020
@alexmt alexmt deleted the external-links-fix branch November 17, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants