Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: PRs with Argo CD and Codefresh #4898

Merged
merged 1 commit into from Nov 24, 2020
Merged

docs: PRs with Argo CD and Codefresh #4898

merged 1 commit into from Nov 24, 2020

Conversation

vfarcic
Copy link
Contributor

@vfarcic vfarcic commented Nov 24, 2020

No description provided.

Signed-off-by: Viktor Farcic <viktor@farcic.com>
@vfarcic
Copy link
Contributor Author

vfarcic commented Nov 24, 2020

@jannfis I made a mess with the previous PR so I'm making a new one (with the same change). This time it's signed.

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #4898 (17f60d6) into master (c214fe0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4898   +/-   ##
=======================================
  Coverage   41.44%   41.44%           
=======================================
  Files         128      128           
  Lines       17666    17666           
=======================================
  Hits         7322     7322           
  Misses       9292     9292           
  Partials     1052     1052           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c214fe0...17f60d6. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vfarcic

@jannfis jannfis merged commit a8a451f into argoproj:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants