fix: correctly compare application destinations with inferred cluster URL #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… URL Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #4937 +/- ##
==========================================
- Coverage 41.44% 41.34% -0.11%
==========================================
Files 128 128
Lines 17666 17695 +29
==========================================
- Hits 7322 7316 -6
- Misses 9292 9330 +38
+ Partials 1052 1049 -3
Continue to review full report at Codecov.
|
kshamajain99
reviewed
Dec 1, 2020
| @@ -2398,6 +2398,17 @@ func (source *ApplicationSource) ExplicitType() (*ApplicationSourceType, error) | |||
|
|
|||
| // Equals compares two instances of ApplicationDestination and return true if instances are equal. | |||
| func (dest ApplicationDestination) Equals(other ApplicationDestination) bool { | |||
| // ignore destination cluster name and isServerInferred fields during comparison | |||
There was a problem hiding this comment.
Do you mean to say that "ignore destination cluster URL" because we are setting dest.Server = ""?
kshamajain99
approved these changes
Dec 1, 2020
alexmt
pushed a commit
that referenced
this pull request
Dec 1, 2020
… URL (#4937) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
rbreeze
pushed a commit
that referenced
this pull request
Jan 12, 2021
… URL (#4937) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4926
Argo CD incorrectly performs full app reconciliation if app destination contains cluster name instead of cluster URL
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com