fix: rollout health could incorrectly report v0.9 rollouts as Progressing #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing Signed-off-by: Jesse Suen <Jesse_Suen@intuit.com>
jessesuen
force-pushed
the
fix-rollout-health-script
branch
from
88780df
to
039014a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4949 +/- ##
=======================================
Coverage 41.25% 41.25%
=======================================
Files 129 129
Lines 17882 17882
=======================================
Hits 7377 7377
Misses 9438 9438
Partials 1067 1067 Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Dec 2, 2020
…sing (#4949) Signed-off-by: Jesse Suen <Jesse_Suen@intuit.com>
rbreeze
pushed a commit
that referenced
this pull request
Jan 12, 2021
…sing (#4949) Signed-off-by: Jesse Suen <Jesse_Suen@intuit.com> Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent modifications I made to the Rollout health lua script could mis-identify a v0.9 Rollout which happened to have a numeric hash, as a v0.10 rollout, and incorrectly report the Rollout as Progressing, even though it was not.
Signed-off-by: Jesse Suen Jesse_Suen@intuit.com