Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list applications filter by name (#4404) #4959

Merged
merged 1 commit into from Dec 4, 2020
Merged

fix: list applications filter by name (#4404) #4959

merged 1 commit into from Dec 4, 2020

Conversation

kshamajain99
Copy link
Contributor

@kshamajain99 kshamajain99 commented Dec 3, 2020 •
edited

Signed-off-by: kshamajain99 kshamajain99@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@kshamajain99
list applications filter by name
8cd22ce 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99 kshamajain99 changed the title fix: list applications filter by name #4404 fix: list applications filter by name (#4404) Dec 3, 2020
mayzhang2000
mayzhang2000 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kshamajain99 kshamajain99 changed the title fix: list applications filter by name (#4404) fix: list applications filter by name Dec 4, 2020
@kshamajain99 kshamajain99 changed the title fix: list applications filter by name fix: list applications filter by name (#4404) Dec 4, 2020
@mayzhang2000 mayzhang2000 merged commit f05ac0c into argoproj:master Dec 4, 2020
rbreeze pushed a commit that referenced this pull request Jan 12, 2021
@kshamajain99 @rbreeze
list applications filter by name (#4959)
f78e0b5 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Signed-off-by: Remington Breeze <remington@breeze.software>
@kshamajain99 kshamajain99 deleted the filter-by-name branch January 20, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayzhang2000 mayzhang2000 mayzhang2000 approved these changes

Assignees

@mayzhang2000 mayzhang2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kshamajain99 @mayzhang2000