Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting 'revision history limit' errors in UI #5035

Merged
merged 1 commit into from Dec 11, 2020

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Dec 10, 2020

Closes #3534

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 9e61354 into argoproj:master Dec 11, 2020
@alexmt alexmt deleted the 3534-ui-set-revision branch December 11, 2020 16:50
alexmt pushed a commit that referenced this pull request Dec 11, 2020
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@keithchong
Copy link
Contributor

keithchong commented Dec 14, 2020

Hi @alexmt , while reviewing this, I saw one issue that is unrelated to the fix.

Please review: #5050

Copy link
Contributor

@keithchong keithchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specific fix LGTM

rbreeze pushed a commit that referenced this pull request Jan 12, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting "revision history limit" errors in UI
3 participants