Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prompt for name for managed resources only when deleting (#5033) #5049

Conversation

keithchong
Copy link
Contributor

Signed-off-by: Keith Chong kykchong@redhat.com

Fixes #5033

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@codecov-io
Copy link

Codecov Report

Merging #5049 (03f80bb) into master (9e61354) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5049   +/-   ##
=======================================
  Coverage   41.27%   41.27%           
=======================================
  Files         129      129           
  Lines       18005    18005           
=======================================
  Hits         7431     7431           
  Misses       9498     9498           
  Partials     1076     1076           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e61354...03f80bb. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you

@alexmt alexmt merged commit e1990fa into argoproj:master Dec 14, 2020
rbreeze pushed a commit that referenced this pull request Jan 12, 2021
…#5049)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask users to enter the name only for managed resources to confirm the deletion
3 participants