Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add resource.Quantity as a known field type for diffing. #5095

Merged
merged 1 commit into from Dec 21, 2020
Merged

feat: Add resource.Quantity as a known field type for diffing. #5095

merged 1 commit into from Dec 21, 2020

Conversation

coderanger
Copy link
Contributor

@coderanger coderanger commented Dec 21, 2020 •
edited

This adds support for direct use of Quantity fields in custom resources. I'm only mostly sure the changes to normalize are correct though, it seems this system previously couldn't handle a direct field as opposed to a nested substruct.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@coderanger
feat: Add resource.Quantity as a known field type for diffing.
e724b5d 
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
@coderanger coderanger changed the title Add resource.Quantity as a known field type for diffing. feat: Add resource.Quantity as a known field type for diffing. Dec 21, 2020
jessesuen
jessesuen approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@jessesuen jessesuen merged commit 5b464c9 into argoproj:master Dec 21, 2020
rbreeze pushed a commit that referenced this pull request Jan 12, 2021
@coderanger @rbreeze
feat: Add resource.Quantity as a known field type for diffing. (#5095)
2dd5ebc 
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
Signed-off-by: Remington Breeze <remington@breeze.software>
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
@coderanger @Shubhama19
feat: Add resource.Quantity as a known field type for diffing. (argop…
43f7984 
…roj#5095)

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
@coderanger coderanger deleted the default-known-types branch July 13, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coderanger @jessesuen