Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch Docker base image to ubuntu:20.10 instead of debian:10-slim #5185

Merged
merged 6 commits into from Jan 5, 2021

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Jan 5, 2021

Switch base image used for building Argo CD's Docker image from debian:10-slim to ubuntu:20.04.

This change should not be user visible, but might affect users who build their own images or use custom tooling. Therefore, this change has been noted in the upgrade notes 1.8 -> 1.9.

Closes #5047
Closes #5155

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
…re/base-use-ubuntu2104

Signed-off-by: jannfis <jann@mistrust.net>
…re/base-use-ubuntu2104

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
…re/base-use-ubuntu2010

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis requested a review from alexmt January 5, 2021 18:48
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit 14b8e3d into argoproj:master Jan 5, 2021
@rumstead
Copy link
Contributor

rumstead commented Jan 5, 2021

trivy image docker.io/argoproj/argocd                                                                                42s 06:24:56 PM
2021-01-05T18:25:26.984-0500	WARN	You should avoid using the :latest tag as it is cached. You need to specify '--clear-cache' option when :latest image is changed
2021-01-05T18:25:55.444-0500	WARN	This OS version is not on the EOL list: ubuntu 20.10
2021-01-05T18:25:55.446-0500	INFO	Detecting Ubuntu vulnerabilities...
2021-01-05T18:25:55.447-0500	INFO	Trivy skips scanning programming language libraries because no supported file was detected
2021-01-05T18:25:55.447-0500	WARN	This OS version is no longer supported by the distribution: ubuntu 20.10
2021-01-05T18:25:55.447-0500	WARN	The vulnerability detection may be insufficient because security updates are not provided

docker.io/argoproj/argocd (ubuntu 20.10)
========================================
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

woohoo!

rbreeze pushed a commit that referenced this pull request Jan 12, 2021
…slim (#5185)

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: Remington Breeze <remington@breeze.software>
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerabilities detected on argocd image Move Docker image away from Debian base image
4 participants