New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include argocd-util as part of release artifacts(#5174) #5203
Conversation
e57d7a2
to
902bd75
Compare
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
902bd75
to
991551c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5203 +/- ##
=======================================
Coverage 40.68% 40.68%
=======================================
Files 136 136
Lines 18420 18420
=======================================
Hits 7494 7494
Misses 9854 9854
Partials 1072 1072
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @kshamajain99, I think this is the right step forward for making argocd-util
more prominent and therefore more usable to the community.
However, I have some concerns about the current implementation. This change now includes two more (very large) binaries into the Docker image, which sum up to about ~150MB in total. Our goal should be to shrink the image.
So I think we need to build a different (potentially temporary) image for the CLIs, from which we upload the binaries to GitHub release, without including the new binaries in the argocd
image.
We could also start a discussion to provide two images with each release: argocd
and argocd-cli
, the former containing none of the CLIs, while the latter will contain CLIs but nothing else.
I agree, this sounds like a better way to do it.
@alexmt any suggestions? |
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
d0387f5
to
c48a5b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @kshamajain99
…argoproj#5203) * Publish argocd-util Signed-off-by: kshamajain99 <kshamajain99@gmail.com> * Don't add util to argocd-image Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
closes #5174
Successful release run: https://github.com/kshamajain99/argo-cd/actions/runs/470230258