Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include argocd-util as part of release artifacts(#5174) #5203

Merged
merged 2 commits into from Jan 8, 2021

Conversation

kshamajain99
Copy link
Contributor

@kshamajain99 kshamajain99 commented Jan 7, 2021

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

closes #5174

Successful release run: https://github.com/kshamajain99/argo-cd/actions/runs/470230258

@kshamajain99 kshamajain99 changed the title feat: Include argocd-util as part of release artifacts feat: Include argocd-util as part of release artifacts(#5174) Jan 7, 2021
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #5203 (c48a5b9) into master (eb9216f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5203   +/-   ##
=======================================
  Coverage   40.68%   40.68%           
=======================================
  Files         136      136           
  Lines       18420    18420           
=======================================
  Hits         7494     7494           
  Misses       9854     9854           
  Partials     1072     1072           
Impacted Files Coverage Δ
controller/sync.go 67.47% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9216f...c48a5b9. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @kshamajain99, I think this is the right step forward for making argocd-util more prominent and therefore more usable to the community.

However, I have some concerns about the current implementation. This change now includes two more (very large) binaries into the Docker image, which sum up to about ~150MB in total. Our goal should be to shrink the image.

So I think we need to build a different (potentially temporary) image for the CLIs, from which we upload the binaries to GitHub release, without including the new binaries in the argocd image.

We could also start a discussion to provide two images with each release: argocd and argocd-cli, the former containing none of the CLIs, while the latter will contain CLIs but nothing else.

@kshamajain99
Copy link
Contributor Author

So I think we need to build a different (potentially temporary) image for the CLIs, from which we upload the binaries to GitHub release, without including the new binaries in the argocd image.

I agree, this sounds like a better way to do it.

We could also start a discussion to provide two images with each release: argocd and argocd-cli, the former containing none of the CLIs, while the latter will contain CLIs but nothing else.

@alexmt any suggestions?

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @kshamajain99

@jannfis jannfis merged commit 98bec61 into argoproj:master Jan 8, 2021
rbreeze pushed a commit that referenced this pull request Jan 12, 2021
* Publish argocd-util

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>

* Don't add util to argocd-image

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Signed-off-by: Remington Breeze <remington@breeze.software>
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
…argoproj#5203)

* Publish argocd-util

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>

* Don't add util to argocd-image

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include argocd-util as part of release artifacts
3 participants