Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade gitops-engine version #5235

Merged
merged 1 commit into from Jan 13, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jan 12, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Closes #4627

@codecov-io
Copy link

Codecov Report

Merging #5235 (9221f66) into master (64e1c38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5235   +/-   ##
=======================================
  Coverage   40.86%   40.86%           
=======================================
  Files         136      136           
  Lines       18453    18453           
=======================================
  Hits         7540     7540           
  Misses       9834     9834           
  Partials     1079     1079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e1c38...9221f66. Read the comment docs.

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt marked this pull request as ready for review January 12, 2021 20:50
@alexmt alexmt requested a review from jgwest January 12, 2021 20:50
@alexmt
Copy link
Collaborator Author

alexmt commented Jan 12, 2021

@jgwest thank you for argoproj/gitops-engine#168 . Is it enough to upgrade to latest gitops engine to close #4627 ?

@jgwest
Copy link
Member

jgwest commented Jan 12, 2021

@alexmt Correct, when argoproj/gitops-engine#168 is adopted #4627 can be closed.

@alexmt alexmt merged commit c9c8bef into argoproj:master Jan 13, 2021
@alexmt alexmt deleted the 4627-cluster-cache-race branch January 13, 2021 19:12
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
…roj#5235)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race between gitops-engine's pkg/cache/cluster.go and itself, on Argo CD startup
4 participants