feat: Add the ability to change user password in the UI #5444

jaredclarke · 2021-02-07T18:28:12Z

Signed-off-by: Jared Clarke jared.clarke@eckoh.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
The title of the PR states what changed and the related issues number (used for the release note).
I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
Does this PR require documentation updates?
I've updated documentation as required by this PR.
Optional. My organization is added to USERS.md.
I have signed off all my commits as required by DCO
My build is green (troubleshooting builds).

codecov-io · 2021-02-07T18:50:42Z

Codecov Report

Merging #5444 (55f9ccb) into master (e22da4a) will increase coverage by 0.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5444      +/-   ##
==========================================
+ Coverage   40.44%   41.19%   +0.75%     
==========================================
  Files         142      148       +6     
  Lines       18936    19874     +938     
==========================================
+ Hits         7658     8188     +530     
- Misses      10187    10567     +380     
- Partials     1091     1119      +28

Impacted Files	Coverage Δ
util/env/env.go	`78.78% <0.00%> (-21.22%)`	⬇️
server/logout/logout.go	`73.07% <0.00%> (-9.43%)`	⬇️
util/helm/helm.go	`60.27% <0.00%> (-3.37%)`	⬇️
util/git/creds.go	`9.62% <0.00%> (-2.68%)`	⬇️
controller/sync.go	`64.88% <0.00%> (-2.60%)`	⬇️
util/helm/cmd.go	`28.57% <0.00%> (-2.30%)`	⬇️
reposerver/repository/repository.go	`60.60% <0.00%> (-1.81%)`	⬇️
util/git/client.go	`47.67% <0.00%> (-1.53%)`	⬇️
controller/state.go	`68.42% <0.00%> (-1.23%)`	⬇️
util/db/repository.go	`62.73% <0.00%> (-1.01%)`	⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22da4a...55f9ccb. Read the comment docs.

rbreeze · 2021-02-08T23:48:00Z

ui/src/app/user-info/components/user-info-overview/user-info-overview.tsx

+                <div className='user-info'>
+                    <div className='argo-container'>
+                        <div className='user-info-overview__panel white-box'>
+                            <DataLoader key='userInfo' load={() => services.users.get()}>


Since this is loading the same data as the DataLoader on line 72, can you combine them please?

I think I've done this in a reasonable way

rbreeze · 2021-02-11T19:50:14Z

ui/src/app/user-info/components/user-info-overview/user-info-overview.tsx

+                            <div className='user-info'>
+                                <div className='argo-container'>
+                                    <div className='user-info-overview__panel white-box'>
+                                        userInfo.loggedIn ? (


Could you fix this? Looks like you just need a { on this line and a matching } at the end of line 64.

fixed - also fixed line 70 & 128 which were missing the same braces

rbreeze

Can you fix this error that occurs when a user clicks the Update Password button but isn't logged in? I think it would be better to hide this button altogether if the user isn't logged in

jannfis

One thing I noted is, that the "Update password" button is also displayed when logged in via SSO.

I think we should make sure to display this button only when the user currently logged in is a local one. This can be done by checking the issuer in the JWT, which has to be argocd in case of local users.

alexmt · 2021-03-01T17:15:45Z

Here is example of isSSO check:

argo-cd/ui/src/app/app.tsx

Line 61 in c6d3728

if (loggedIn && iss !== 'argocd') {

Signed-off-by: Jared Clarke <jared.clarke@eckoh.com>

rbreeze

I still don't see a check for whether the user is logged in with SSO. Could you add this please?

Signed-off-by: Jared Clarke <jared.clarke@eckoh.com>

jaredclarke · 2021-05-19T00:02:09Z

I still don't see a check for whether the user is logged in with SSO. Could you add this please?

https://github.com/argoproj/argo-cd/pull/5444/files#diff-0e6721e087b5175a38e352b36e08d9ef0a6b18a5d0a30769babf799768b83c11R36

I originally added the iss check against the button being displayed but have now added this to the main sliding panel as well

reviewer notes had been addressed

jaredclarke force-pushed the add-change-password-ui branch from a911457 to 87fb362 Compare February 7, 2021 18:29

jaredclarke mentioned this pull request Feb 7, 2021

Add ability for users to update their passwords through the UI #5433

Closed

jaredclarke force-pushed the add-change-password-ui branch from 87fb362 to eb65d8b Compare February 7, 2021 18:40

rbreeze self-assigned this Feb 8, 2021

rbreeze requested changes Feb 8, 2021

View reviewed changes

jaredclarke force-pushed the add-change-password-ui branch 2 times, most recently from 5330c49 to cff8f81 Compare February 9, 2021 09:33

rbreeze requested changes Feb 11, 2021

View reviewed changes

jaredclarke force-pushed the add-change-password-ui branch from cff8f81 to 6d4d4c7 Compare February 11, 2021 22:04

rbreeze requested changes Feb 17, 2021

View reviewed changes

jaredclarke force-pushed the add-change-password-ui branch from 6d4d4c7 to 2910c08 Compare February 18, 2021 14:53

jannfis previously requested changes Mar 1, 2021

View reviewed changes

feat: Add the ability to change user password

80845c0

Signed-off-by: Jared Clarke <jared.clarke@eckoh.com>

jaredclarke force-pushed the add-change-password-ui branch from c70423c to 80845c0 Compare March 11, 2021 18:15

jaredclarke requested review from jannfis and rbreeze April 18, 2021 09:29

rbreeze requested changes May 17, 2021

View reviewed changes

fixup! feat: Add the ability to change user password

55f9ccb

Signed-off-by: Jared Clarke <jared.clarke@eckoh.com>

jaredclarke force-pushed the add-change-password-ui branch from c864e5a to 55f9ccb Compare May 19, 2021 00:01

rbreeze approved these changes Jun 2, 2021

View reviewed changes

alexmt approved these changes Jun 2, 2021

View reviewed changes

alexmt merged commit d6f579b into argoproj:master Jun 2, 2021

jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021

jaredclarke deleted the add-change-password-ui branch July 7, 2021 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add the ability to change user password in the UI #5444

feat: Add the ability to change user password in the UI #5444

jaredclarke commented Feb 7, 2021 •

edited

codecov-io commented Feb 7, 2021 •

edited by codecov bot

rbreeze Feb 8, 2021

jaredclarke Feb 9, 2021

rbreeze Feb 11, 2021

jaredclarke Feb 11, 2021

rbreeze left a comment

jannfis left a comment

alexmt commented Mar 1, 2021

rbreeze left a comment

jaredclarke commented May 19, 2021

feat: Add the ability to change user password in the UI #5444

feat: Add the ability to change user password in the UI #5444

Conversation

jaredclarke commented Feb 7, 2021 • edited

codecov-io commented Feb 7, 2021 • edited by codecov bot

Codecov Report

rbreeze Feb 8, 2021

Choose a reason for hiding this comment

jaredclarke Feb 9, 2021

Choose a reason for hiding this comment

rbreeze Feb 11, 2021

Choose a reason for hiding this comment

jaredclarke Feb 11, 2021

Choose a reason for hiding this comment

rbreeze left a comment

Choose a reason for hiding this comment

jannfis left a comment

Choose a reason for hiding this comment

alexmt commented Mar 1, 2021

rbreeze left a comment

Choose a reason for hiding this comment

jaredclarke commented May 19, 2021

jaredclarke commented Feb 7, 2021 •

edited

codecov-io commented Feb 7, 2021 •

edited by codecov bot