Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add health check for Sealed Secrets #5503

Merged
merged 1 commit into from Feb 12, 2021

Conversation

chetan-rns
Copy link
Member

This PR adds a Lua script, which updates the health status of an application based on sealed secret's status

Fixes: #4754

Signed-off-by: Chetan Banavikalmutt chetanrns1997@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

This commit adds a lua script, which updates the health status of an application based on sealed secret's status

Fixes: argoproj#4754

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #5503 (139a2a5) into master (223335d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5503      +/-   ##
==========================================
+ Coverage   40.77%   40.80%   +0.02%     
==========================================
  Files         143      143              
  Lines       18985    18886      -99     
==========================================
- Hits         7741     7706      -35     
+ Misses      10151    10093      -58     
+ Partials     1093     1087       -6     
Impacted Files Coverage Δ
server/application/application.go 28.87% <0.00%> (-1.29%) ⬇️
server/session/ratelimiter.go 100.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/register.go 0.00% <0.00%> (ø)
server/application/broadcaster.go 78.57% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 223335d...139a2a5. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @chetan-rns !

@jannfis jannfis merged commit 6a19451 into argoproj:master Feb 12, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
This commit adds a lua script, which updates the health status of an application based on sealed secret's status

Fixes: argoproj#4754

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize failures to decrypt sealed secrets
3 participants