Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude kube-root-ca.crt ConfigMap from Orphaned Resources monit… #5523

Merged
merged 1 commit into from Feb 17, 2021

Conversation

iam-veeramalla
Copy link
Member

@iam-veeramalla iam-veeramalla commented Feb 16, 2021

…oring by default (#5490)

Signed-off-by: iam-veeramalla abhishek.veeramalla@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

…oring by default (argoproj#5490)

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #5523 (2fafeb5) into master (d342993) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5523      +/-   ##
==========================================
- Coverage   40.88%   40.87%   -0.01%     
==========================================
  Files         143      143              
  Lines       18901    18903       +2     
==========================================
  Hits         7727     7727              
- Misses      10090    10091       +1     
- Partials     1084     1085       +1     
Impacted Files Coverage Δ
controller/appcontroller.go 53.44% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d342993...2fafeb5. Read the comment docs.

@iam-veeramalla iam-veeramalla marked this pull request as ready for review February 17, 2021 09:52
@iam-veeramalla
Copy link
Member Author

@jannfis Please have a look at this, whenever possible, I don't think we can add any additional e2e tests for this feature as 1. It fixes the failures of current tests.
2. ConfigMap "kube-root-ca.crt" is installed by default.

@jannfis
Copy link
Member

jannfis commented Feb 17, 2021

Yep, you are right @iam-veeramalla - once we start adding a 1.20 cluster to the end-to-end tests, we'd immediately notice a regression in CI. Thank you!

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested against a 1.20 cluster and tests are passing 🎉

Thank you @iam-veeramalla

@jannfis jannfis merged commit 73edc0a into argoproj:master Feb 17, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
…oring by default (argoproj#5490) (argoproj#5523)

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants