fix: Empty resource whitelist allowed all resources (#5540) #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangraefen
changed the title
jangraefen
force-pushed
the
fix/cluster-resources-whitelist
branch
from
8d8b1d7
to
9e0b346
Compare
jangraefen
changed the title
jangraefen
force-pushed
the
fix/cluster-resources-whitelist
branch
from
9e0b346
to
b68f4fe
Compare
This requires setting the default in quite a few places around the code base as well as adapting a couple of tests Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com>
jangraefen
force-pushed
the
fix/cluster-resources-whitelist
branch
from
b68f4fe
to
3e98e04
Compare
|
The CodeQL fail seems to be unrelated to my change, so here goes nothing. |
|
Thanks for your PR, @jangraefen. Before reviewing & merging this one, we should make sure that it's the correct intended behavior as discussed in #5540.
FWIW, I submitted two PRs (#5563, #5564) to fix the CodeQL complaints. |
Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com>
jangraefen
force-pushed
the
fix/cluster-resources-whitelist
branch
from
2f7f994
to
7fe0217
Compare
Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com>
jangraefen
force-pushed
the
fix/cluster-resources-whitelist
branch
from
7fe0217
to
eadcfe5
Compare
Codecov Report
@@ Coverage Diff @@
## master #5551 +/- ##
==========================================
+ Coverage 40.90% 40.92% +0.02%
==========================================
Files 144 144
Lines 19214 19214
==========================================
+ Hits 7860 7864 +4
+ Misses 10258 10255 -3
+ Partials 1096 1095 -1
Continue to review full report at Codecov.
|
Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com>
jannfis
approved these changes
Mar 1, 2021
jannfis
added
the
cherry-pick/1.8
|
@alexmt Shall we cherry-pick this into 1.8 (and possibly 1.7) as well? |
|
agree, cherry-picking |
alexmt
pushed a commit
that referenced
this pull request
Mar 1, 2021
* fix: Empty resource whitelist allowed all resources This requires setting the default in quite a few places around the code base as well as adapting a couple of tests Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com> * Improve default behavior and not require explicitly set whitelist Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com>
alexmt
pushed a commit
that referenced
this pull request
Mar 1, 2021
* fix: Empty resource whitelist allowed all resources This requires setting the default in quite a few places around the code base as well as adapting a couple of tests Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com> * Improve default behavior and not require explicitly set whitelist Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com>
shubhamagarwal19
pushed a commit
to shubhamagarwal19/argo-cd
that referenced
this pull request
Apr 15, 2021
…rgoproj#5551) * fix: Empty resource whitelist allowed all resources This requires setting the default in quite a few places around the code base as well as adapting a couple of tests Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com> * Improve default behavior and not require explicitly set whitelist Signed-off-by: Jan Graefen <223234+jangraefen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5540
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: