-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Information header for selected resource panel #5557
Conversation
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Codecov Report
@@ Coverage Diff @@
## master #5557 +/- ##
==========================================
+ Coverage 40.93% 40.97% +0.03%
==========================================
Files 147 147
Lines 19661 19691 +30
==========================================
+ Hits 8049 8069 +20
- Misses 10508 10518 +10
Partials 1104 1104
Continue to review full report at Codecov.
|
Signed-off-by: Remington Breeze <remington@breeze.software>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement of resource details panel!
However, can we switch to new tabs in a separate PR? If we are switching to new tabs style then we should switch everywhere (probably including argo workflow). We should discuss new tabs style at least once before migrating.
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also includes refactored Tabs component that's functional instead of class-based.
Checklist: