Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Information header for selected resource panel #5557

Merged
merged 14 commits into from
Apr 20, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Feb 19, 2021

Also includes refactored Tabs component that's functional instead of class-based.

Screen Shot 2021-02-18 at 5 37 57 PM

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #5557 (60c5e9b) into master (61080b3) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5557      +/-   ##
==========================================
+ Coverage   40.93%   40.97%   +0.03%     
==========================================
  Files         147      147              
  Lines       19661    19691      +30     
==========================================
+ Hits         8049     8069      +20     
- Misses      10508    10518      +10     
  Partials     1104     1104              
Impacted Files Coverage Δ
reposerver/repository/repository.go 61.66% <0.00%> (-0.40%) ⬇️
util/git/creds.go 9.62% <0.00%> (ø)
util/helm/helm.go 60.27% <0.00%> (ø)
util/cache/redis.go 48.83% <0.00%> (ø)
util/helm/client.go 45.02% <0.00%> (ø)
server/cache/cache.go 73.33% <0.00%> (ø)
util/oidc/provider.go 0.00% <0.00%> (ø)
util/session/state.go 69.81% <0.00%> (ø)
util/cache/inmemory.go 35.13% <0.00%> (ø)
util/ksonnet/ksonnet.go 40.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61080b3...60c5e9b. Read the comment docs.

@rbreeze rbreeze requested a review from alexmt February 26, 2021 22:52
@rbreeze rbreeze added this to the v2.1 milestone Mar 2, 2021
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement of resource details panel!

However, can we switch to new tabs in a separate PR? If we are switching to new tabs style then we should switch everywhere (probably including argo workflow). We should discuss new tabs style at least once before migrating.

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt April 17, 2021 01:07
Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 1bffd82 into argoproj:master Apr 20, 2021
@rbreeze rbreeze deleted the panel-header branch April 20, 2021 22:07
@alexmt alexmt added the needs-verification PR requires pre-release verification label Jul 28, 2021
@rbreeze rbreeze removed the needs-verification PR requires pre-release verification label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants