-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Keyboard shortcuts #5601
Conversation
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Codecov Report
@@ Coverage Diff @@
## master #5601 +/- ##
==========================================
+ Coverage 40.93% 40.97% +0.03%
==========================================
Files 147 147
Lines 19661 19691 +30
==========================================
+ Hits 8049 8069 +20
- Misses 10508 10518 +10
Partials 1104 1104
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Added reminder to remove the unused component.
LGTM After resolving it.
field='spec.source.repoURL' | ||
component={AutocompleteField} | ||
componentProps={{items: repos}} | ||
{false && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This FormField
is not rendered due to {false && (
, correct? Remove it please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was to silence a compiler error while I was debugging, forgot to remove it. Thank you for catching it!
Signed-off-by: Remington Breeze <remington@breeze.software>
Addendum #6859 |
Fixes #5466
Shortcuts:
/
key to searchAlso moves/redesigns search bar:
Checklist: