Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix memory leak in application controller #5604

Merged
merged 5 commits into from Feb 25, 2021
Merged

fix: fix memory leak in application controller #5604

merged 5 commits into from Feb 25, 2021

Conversation

kshamajain99
Copy link
Contributor

@kshamajain99 kshamajain99 commented Feb 25, 2021 •
edited

closes #5578

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@kshamajain99
fix: support longer cookie
8854641 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99
fix memory leak in controller
5c43b96 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99
merge conflicts
5cc0095 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99
fix: support longer cookie
a0c91e5 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99
merge conflicts
a1b4f15 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
alexmt
alexmt approved these changes Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit 7ad79e5 into argoproj:master Feb 25, 2021
alexmt pushed a commit that referenced this pull request Feb 26, 2021
@kshamajain99 @alexmt
fix: fix memory leak in application controller (#5604)
0b3333e 
fix: fix memory leak in application controller
alexmt pushed a commit that referenced this pull request Feb 26, 2021
@kshamajain99 @alexmt
fix: fix memory leak in application controller (#5604)
f2562b4 
fix: fix memory leak in application controller
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
@kshamajain99 @Shubhama19
fix: fix memory leak in application controller (argoproj#5604)
5f13d55 
fix: fix memory leak in application controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak when cluster name is specified with a trailing slash
2 participants
@kshamajain99 @alexmt