Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding noscript tag to index.html issue #5478 #5650

Merged
merged 2 commits into from Mar 8, 2021

Conversation

anais-codefresh
Copy link
Contributor

Fixes [ISSUE #5478]

This is my first PR so not I am not too sure how to fill out the below checklist.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@jannfis
Copy link
Member

jannfis commented Mar 2, 2021

Hi @anais-codefresh, and many thanks for helping to improve Argo CD with your PR!

To make the CI happy, please:

  • Prefix the PR title using fix: (this indicates that the PR resolves a bug issue), so the Semantic PR title check is happy
  • Sign-off your commit in Git so that the DCO check is happy

@anais-codefresh anais-codefresh changed the title Adding noscript tag to index.html issue #5478 fix: Adding noscript tag to index.html issue #5478 Mar 8, 2021
Signed-off-by: anais-codefresh <anais.urlichs@codefresh.io>
@anais-codefresh
Copy link
Contributor Author

Hey @jannfis lmk if this is ok like that :)

@jannfis
Copy link
Member

jannfis commented Mar 8, 2021

Thank you, @anais-codefresh. Somehow, CodeQL complains now about an already fixed issue. I believe this can be fixed by rebasing your PR to latest master-branch code. Once you've done that, and CodeQL is happy too, I'll merge the change.

…ntent

Signed-off-by: anais-codefresh <anais.urlichs@codefresh.io>
@codecov-io
Copy link

Codecov Report

Merging #5650 (ee9cb64) into master (90602a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5650   +/-   ##
=======================================
  Coverage   40.96%   40.96%           
=======================================
  Files         144      144           
  Lines       19398    19398           
=======================================
  Hits         7946     7946           
  Misses      10340    10340           
  Partials     1112     1112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90602a7...ee9cb64. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @anais-codefresh !

@jannfis jannfis merged commit a0a5455 into argoproj:master Mar 8, 2021
@jannfis jannfis mentioned this pull request Mar 8, 2021
3 tasks
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: anais-codefresh <anais.urlichs@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants