Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capitalization in headers #5692

Merged

Conversation

reginapizza
Copy link
Contributor

@reginapizza reginapizza commented Mar 4, 2021

Closes #5691

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Screenshot from 2021-03-04 17-54-02
Screenshot from 2021-03-04 17-54-24

Note: STATUS BADGE header (when enabled) will also be capitalized, however this will be incorporated in PR #5678

Signed-off-by: Regina Scott <rescott@redhat.com>
@reginapizza reginapizza force-pushed the issue5691-header-capitalization branch from 3cc2c60 to 260b7a7 Compare March 4, 2021 22:57
@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

Merging #5692 (3cc2c60) into master (d8cb02b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5692   +/-   ##
=======================================
  Coverage   40.96%   40.96%           
=======================================
  Files         144      144           
  Lines       19395    19395           
=======================================
  Hits         7945     7945           
  Misses      10339    10339           
  Partials     1111     1111           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cb02b...260b7a7. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch, thank you!

@jannfis jannfis merged commit 022a130 into argoproj:master Mar 5, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: Regina Scott <rescott@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capitalization in Headers
3 participants