feat: support resource prune propagation policy #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
alexmt
force-pushed
the
prune-propagation-policy
branch
2 times, most recently
from
d4a5147
to
16fd2c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #5743 +/- ##
==========================================
- Coverage 40.77% 40.77% -0.01%
==========================================
Files 146 146
Lines 19511 19519 +8
==========================================
+ Hits 7956 7958 +2
- Misses 10443 10449 +6
Partials 1112 1112
Continue to review full report at Codecov.
|
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
prune-propagation-policy
branch
from
16fd2c9
to
a9c23db
Compare
|
On a side note, I don't think it closes #5724 just yet, because we don't change the default. |
|
Agree, removing #5724 from the description |
shubhamagarwal19
pushed a commit
to shubhamagarwal19/argo-cd
that referenced
this pull request
Apr 15, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Depends on argoproj/gitops-engine#235
PR introduces the ability to specify resource prune propagation policy. The default stays 'foreground' but can be changed at the application level using sync option:
Closes #3928