Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run server as nonroot with non-read-root-fs #5820

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

sbose78
Copy link
Contributor

@sbose78 sbose78 commented Mar 19, 2021

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

capabilities:
drop:
- all
volumes:
- emptyDir: {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't feel too comfortable mounting /home/argocd as emptydir: {}

Signed-off-by: Shoubhik Bose <shbose@redhat.com>
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5820 (d76139f) into master (84f0594) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5820      +/-   ##
==========================================
- Coverage   41.02%   41.00%   -0.02%     
==========================================
  Files         146      146              
  Lines       19616    19630      +14     
==========================================
+ Hits         8047     8049       +2     
- Misses      10455    10466      +11     
- Partials     1114     1115       +1     
Impacted Files Coverage Δ
util/settings/settings.go 39.46% <0.00%> (-0.48%) ⬇️
cmd/argocd/commands/app.go 0.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 57.44% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f0594...d76139f. Read the comment docs.

@alexmt alexmt added this to the v2.1 milestone Apr 15, 2021
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 3d3a250 into argoproj:master Apr 15, 2021
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants