chore: Fix manifest generation in release and make quay.io the lead #5831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <jann@mistrust.net>
Codecov Report
@@ Coverage Diff @@
## master #5831 +/- ##
=======================================
Coverage 41.01% 41.01%
=======================================
Files 146 146
Lines 19630 19630
=======================================
Hits 8052 8052
Misses 10464 10464
Partials 1114 1114 Continue to review full report at Codecov.
|
jannfis
added
the
cherry-pick/2.0
.github/workflows/release.yaml
Outdated
| docker push ${IMAGE_NAMESPACE}/argocd:v${TARGET_VERSION} | ||
| # Remove the following when Docker Hub is gone | ||
| docker login --username "${DOCKER_USERNAME}" --password "${DOCKER_TOKEN}" | ||
| docker tag ${IMAGE_NAMESPACE}/argocd:v${TARGET_VERSION} argoproj/argocd:v${TARGET_VERSION} | ||
| docker push quay.io/${IMAGE_NAMESPACE}/argocd:v${TARGET_VERSION} |
There was a problem hiding this comment.
I think this docker push line needs to be changed as well, in order to push to docker hub instead of quay.io
docker push argoproj/argocd:v${TARGET_VERSION}
There was a problem hiding this comment.
Good catch! Will fix it.
Signed-off-by: jannfis <jann@mistrust.net>
sbose78
approved these changes
Mar 24, 2021
alexmt
pushed a commit
that referenced
this pull request
Mar 29, 2021
…5831) * chore: Fix manifest generation in release and make quay.io the lead Signed-off-by: jannfis <jann@mistrust.net> * Fix docker push command Signed-off-by: jannfis <jann@mistrust.net>
shubhamagarwal19
pushed a commit
to shubhamagarwal19/argo-cd
that referenced
this pull request
Apr 15, 2021
…rgoproj#5831) * chore: Fix manifest generation in release and make quay.io the lead Signed-off-by: jannfis <jann@mistrust.net> * Fix docker push command Signed-off-by: jannfis <jann@mistrust.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jannfis jann@mistrust.net
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: