feat: add exit-code flag to app diff command (#5768) #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using exit-code flag we could control the exit status of the command when there's a diff. Example: argocd app diff sample --local /path --exit-code=false The above command will return exit code 0 even if it finds a diff. Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5852 +/- ##
==========================================
- Coverage 41.01% 41.01% -0.01%
==========================================
Files 146 146
Lines 19630 19632 +2
==========================================
Hits 8052 8052
- Misses 10464 10466 +2
Partials 1114 1114
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Mar 29, 2021
Using exit-code flag we could control the exit status of the command when there's a diff. Example: argocd app diff sample --local /path --exit-code=false The above command will return exit code 0 even if it finds a diff. Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
shubhamagarwal19
pushed a commit
to shubhamagarwal19/argo-cd
that referenced
this pull request
Apr 15, 2021
Using exit-code flag we could control the exit status of the command when there's a diff. Example: argocd app diff sample --local /path --exit-code=false The above command will return exit code 0 even if it finds a diff. Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the exit-code flag we could control the exit status of the command when there's a diff.
Example:
The above command will return exit code 0 even when it finds a diff.
Fixes: #5768
Signed-off-by: Chetan Banavikalmutt chetanrns1997@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: