Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sourceRepos and destinations info of global project is missing in UI #5861

Merged
merged 1 commit into from Mar 26, 2021

Conversation

mayzhang2000
Copy link
Contributor

@mayzhang2000 mayzhang2000 commented Mar 24, 2021

Signed-off-by: May Zhang may_zhang@intuit.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

fixes: #5860

Signed-off-by: May Zhang <may_zhang@intuit.com>
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #5861 (7bc8243) into master (733587e) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5861      +/-   ##
==========================================
- Coverage   41.07%   40.88%   -0.19%     
==========================================
  Files         146      147       +1     
  Lines       19520    19617      +97     
==========================================
+ Hits         8018     8021       +3     
- Misses      10397    10491      +94     
  Partials     1105     1105              
Impacted Files Coverage Δ
server/application/application.go 30.55% <100.00%> (ø)
util/localconfig/localconfig.go 3.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733587e...7bc8243. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 26af455 into argoproj:master Mar 26, 2021
alexmt pushed a commit that referenced this pull request Mar 29, 2021
Signed-off-by: May Zhang <may_zhang@intuit.com>
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: May Zhang <may_zhang@intuit.com>
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@mayzhang2000 mayzhang2000 removed the needs-verification PR requires pre-release verification label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Argocd2.0-rc1] Global project sourceRepos and destinations are not shown in UI
3 participants