Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watch application, label selector is not used when name variable is not set #5975

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

xuhrc
Copy link
Contributor

@xuhrc xuhrc commented Apr 6, 2021

Fixes #5974 when name variable is empty, the label selector is not used.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@xuhrc xuhrc changed the title Fixes [5974#] label selector is useless when name variable is not set Fixes [#5974] label selector is useless when name variable is not set Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #5975 (a976b33) into master (1bc3348) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5975   +/-   ##
=======================================
  Coverage   40.91%   40.91%           
=======================================
  Files         147      147           
  Lines       19635    19635           
=======================================
  Hits         8033     8033           
  Misses      10497    10497           
  Partials     1105     1105           
Impacted Files Coverage Δ
server/application/application.go 30.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc3348...a976b33. Read the comment docs.

@xuhrc xuhrc changed the title Fixes [#5974] label selector is useless when name variable is not set Fixes [#5974] label selector is not used when name variable is not set Apr 6, 2021
when name variable is empty, the label selector is useless.

Signed-off-by: stanhrxu <stanhrxu@tencent.com>
@xuhrc xuhrc changed the title Fixes [#5974] label selector is not used when name variable is not set Fixes [#5974] watch application, label selector is not used when name variable is not set Apr 6, 2021
@xuhrc xuhrc changed the title Fixes [#5974] watch application, label selector is not used when name variable is not set fix: watch application, label selector is not used when name variable is not set Apr 8, 2021
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @xuhrc ! Thank you!

@alexmt alexmt merged commit 9a788c3 into argoproj:master Jul 12, 2021
@alexmt alexmt self-assigned this Jul 12, 2021
@alexmt alexmt added this to the v2.1 milestone Jul 12, 2021
@alexmt alexmt added the needs-verification PR requires pre-release verification label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires pre-release verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application watch filter, label selector will be ignored if [queryRequest.name] not set
2 participants