Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file descriptor leak #6064

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

ishitasequeira
Copy link
Member

Resolves issue #5779

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed off by Ishita Sequeira

Signed-off-by: Ishita Sequeira <isequeir@redhat.com>
@alexmt
Copy link
Collaborator

alexmt commented Apr 20, 2021

Thank you!

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@3e43eca). Click here to learn what that means.
The diff coverage is 62.50%.

❗ Current head 0de59ad differs from pull request most recent head 12a299f. Consider uploading reports for the commit 12a299f to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6064   +/-   ##
=========================================
  Coverage          ?   40.93%           
=========================================
  Files             ?      147           
  Lines             ?    19729           
  Branches          ?        0           
=========================================
  Hits              ?     8077           
  Misses            ?    10541           
  Partials          ?     1111           
Impacted Files Coverage Δ
reposerver/repository/repository.go 60.76% <ø> (ø)
util/helm/cmd.go 28.57% <0.00%> (ø)
util/db/gpgkeys.go 79.10% <100.00%> (ø)
util/gpg/gpg.go 68.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e43eca...12a299f. Read the comment docs.

@ishitasequeira ishitasequeira marked this pull request as ready for review April 20, 2021 01:13
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 31d66bc into argoproj:master Apr 20, 2021
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@jgwest jgwest removed the needs-verification PR requires pre-release verification label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants