Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add view toggle to hide/show unschedulable node in pod view #6263

Merged
merged 1 commit into from
May 19, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented May 18, 2021

Fixes #6261

Screen Shot 2021-05-18 at 11 24 26 AM

Screen Shot 2021-05-18 at 11 24 30 AM

Signed-off-by: Remington Breeze remington@breeze.software

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Remington Breeze <remington@breeze.software>
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #6263 (cb7552f) into master (5c41377) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6263      +/-   ##
==========================================
- Coverage   41.21%   41.18%   -0.03%     
==========================================
  Files         147      148       +1     
  Lines       19862    19874      +12     
==========================================
  Hits         8186     8186              
- Misses      10556    10568      +12     
  Partials     1120     1120              
Impacted Files Coverage Δ
util/git/client.go 47.67% <0.00%> (-0.38%) ⬇️
util/git/ssh.go 0.00% <0.00%> (ø)
util/settings/settings.go 46.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434af15...cb7552f. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit e959c3b into argoproj:master May 19, 2021
@alexmt alexmt added the needs-verification PR requires pre-release verification label Jul 28, 2021
@rbreeze rbreeze removed the needs-verification PR requires pre-release verification label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to hide Unschedulable "Node" in Pod View
2 participants