fix: userinfo /v1/session/userinfo should return authenticated=false if token has expired #6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
force-pushed
the
5897-readonly-relogin
branch
from
9fdc670
to
d7941f8
Compare
|
cc @jMarkP . Sorry, during #5897 review I did not realize that UI needs token info from |
Codecov Report
@@ Coverage Diff @@
## master #6282 +/- ##
==========================================
- Coverage 41.10% 41.08% -0.03%
==========================================
Files 151 151
Lines 19931 19931
==========================================
- Hits 8192 8188 -4
- Misses 10611 10613 +2
- Partials 1128 1130 +2
Continue to review full report at Codecov.
|
…if token has expired Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
5897-readonly-relogin
branch
from
d7941f8
to
eea45f1
Compare
|
Ah I see. Apologies for that. I'd come from the assumption that lapsed login === no login. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5687
PR rollbacks #5897 since it broke re-load feature. Instead it implements another approach that fixes #5687. The /v1/session/userinfo API should return
{"authenticated": true}only if the provided token is valid and not expired. So only second commit eea45f1 needs review.