Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade Helm to v3.6.0 and pass --kube-version to templating #6359

Merged
merged 1 commit into from
May 29, 2021

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented May 28, 2021

This PR upgrades Helm to v3.6.0, which contains a new feature to pass --kube-version to helm template (helm/helm#9040).

Also, enable this feature in our code.

Also fixes #5833

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #6359 (7e5f265) into master (2a7745b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6359   +/-   ##
=======================================
  Coverage   40.90%   40.91%           
=======================================
  Files         151      151           
  Lines       20021    20021           
=======================================
+ Hits         8189     8191    +2     
+ Misses      10705    10704    -1     
+ Partials     1127     1126    -1     
Impacted Files Coverage Δ
util/helm/helmver.go 80.00% <ø> (ø)
util/helm/cmd.go 29.81% <0.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7745b...7e5f265. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with syncing of app due to conditional using semverCompare seemingly not being evaluated
2 participants