Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo-server should reset manifests cache when k8s version/api versions change #6434

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 8, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

PR ensures that repo server regenerates manifests when K8S version or list of support API versions change

Closes #5643

@alexmt alexmt requested a review from mayzhang2000 June 8, 2021 20:05
@alexmt alexmt force-pushed the 5643-app-cache-cluster-apis branch 2 times, most recently from f3afe6a to 7e635d8 Compare June 8, 2021 20:41
…rsions change

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt force-pushed the 5643-app-cache-cluster-apis branch from 7e635d8 to 9da869d Compare June 8, 2021 21:06
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #6434 (9da869d) into master (faba995) will decrease coverage by 0.01%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6434      +/-   ##
==========================================
- Coverage   41.01%   40.99%   -0.02%     
==========================================
  Files         152      152              
  Lines       20088    20112      +24     
==========================================
+ Hits         8239     8245       +6     
- Misses      10716    10732      +16     
- Partials     1133     1135       +2     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 57.89% <0.00%> (-0.18%) ⬇️
util/webhook/webhook.go 62.56% <16.66%> (-3.53%) ⬇️
reposerver/cache/cache.go 64.51% <58.33%> (-2.93%) ⬇️
controller/clusterinfoupdater.go 36.20% <100.00%> (+1.11%) ⬆️
reposerver/repository/repository.go 60.85% <100.00%> (ø)
server/server.go 54.95% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adba69...9da869d. Read the comment docs.

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 3dd5dc4 into argoproj:master Jun 8, 2021
@alexmt alexmt deleted the 5643-app-cache-cluster-apis branch June 8, 2021 23:10
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster cache requires manual refresh
3 participants