fix: re-use same http transport in grpc proxy to avoid goroutine leak #6444
+14
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
6026-grpc-proxy-leak
branch
from
0ddf0a4
to
7648ca0
Compare
Codecov Report
@@ Coverage Diff @@
## master #6444 +/- ##
=======================================
Coverage 41.02% 41.02%
=======================================
Files 152 152
Lines 20131 20131
=======================================
Hits 8259 8259
Misses 10733 10733
Partials 1139 1139
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Closes #6026
PR changes grpc proxy so that it uses the same http client and stop leaking goroutins. Thanks to @uturunku1 for implementing this change!