Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app hard refresh should refresh cached app details #6463

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jun 11, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Closes #4889

The application.Get API should force refresh app details cache if "hard" app refresh is requested.

@alexmt alexmt requested a review from mayzhang2000 June 11, 2021 18:58
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #6463 (628c8a6) into master (2da0e81) will increase coverage by 0.02%.
The diff coverage is 36.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6463      +/-   ##
==========================================
+ Coverage   41.07%   41.10%   +0.02%     
==========================================
  Files         152      152              
  Lines       20144    20164      +20     
==========================================
+ Hits         8274     8288      +14     
- Misses      10734    10735       +1     
- Partials     1136     1141       +5     
Impacted Files Coverage Δ
server/application/application.go 31.71% <35.59%> (+0.82%) ⬆️
reposerver/repository/repository.go 60.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da0e81...628c8a6. Read the comment docs.

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 2c966f2 into argoproj:master Jun 15, 2021
@alexmt alexmt deleted the 4889-refresh-app-details branch June 15, 2021 18:48
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm url values.yaml not refreshing
3 participants